Skip to content

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Dec 10, 2024

Issue number: internal


What is the new behavior?

This is part of a bigger task to add focus styles on all components that need them on Ionic Theme. A separate PR will be done for each component.

  • Added new focus styles for segment on Ionic theme.
  • Added new state test and snapshots.
  • UI is slightly different from Figma, but t was discussed and aligned with UX/UI.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Dec 10, 2024
@vercel
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 9:04am

@BenOsodrac BenOsodrac marked this pull request as ready for review December 10, 2024 18:15
@BenOsodrac BenOsodrac requested a review from a team as a code owner December 10, 2024 18:15
@BenOsodrac BenOsodrac requested review from OS-giulianasilva, tanner-reits and thetaPC and removed request for OS-giulianasilva and thetaPC December 10, 2024 18:15
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit 4a6bcab into next Dec 12, 2024
46 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11445-segment branch December 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants